Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load partials and helpers before compile if isCached is false #132

Merged
merged 4 commits into from Nov 17, 2017

Conversation

@wswoodruff
Copy link
Contributor

wswoodruff commented Nov 11, 2017

Why this change? If isCached is false, then users expect there to be changes when the file on disk changes. Build tools like BrowserSync also reload when files on disk change, so this adds a lot of 'it just works' value

Feedback welcome!

@wswoodruff

This comment has been minimized.

Copy link
Contributor Author

wswoodruff commented Nov 11, 2017

Added tests, and bust require's cache if isCached is set to false

@hapijs hapijs deleted a comment from coveralls Nov 13, 2017
@hapijs hapijs deleted a comment from coveralls Nov 13, 2017
@hapijs hapijs deleted a comment from coveralls Nov 13, 2017
@hapijs hapijs deleted a comment from coveralls Nov 13, 2017
@hapijs hapijs deleted a comment from coveralls Nov 13, 2017
@hapijs hapijs deleted a comment from coveralls Nov 13, 2017
@wswoodruff wswoodruff added this to the 5.2.0 milestone Nov 15, 2017
@wswoodruff wswoodruff force-pushed the recompile-partials branch from eb39ad0 to d7267d4 Nov 17, 2017
@wswoodruff wswoodruff merged commit e002565 into master Nov 17, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@wswoodruff wswoodruff deleted the recompile-partials branch Dec 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.