Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix crash when no global context is supplied, no handler context is supplied, and a layout template is being used #17
Conversation
This comment has been minimized.
This comment has been minimized.
|
If you recreate the situation described in #16, that should give you a test right? You know the situation you need to create to make this happen. The fact that coverage is still 100% means that both sides of |
This comment has been minimized.
This comment has been minimized.
|
@Torsph I have created a test case for your reference. Feel free to pull/modify it as you see fit. |
This comment has been minimized.
This comment has been minimized.
…upplied, and a layout template is being used
Torsph
force-pushed the
Torsph:fix_missing_context_crash
branch
from
14c8395
to
008c66d
This comment has been minimized.
This comment has been minimized.
|
@jagoda I just made the test name a bit more specific. |
This comment has been minimized.
This comment has been minimized.
|
@Torsph cool. Works for me. |
arb
added a commit
that referenced
this pull request
Nov 13, 2014
Fix crash when no global context is supplied, no handler context is supplied, and a layout template is being used
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Torsph commentedNov 13, 2014
Fix crash when no global context is supplied, no handler context is supplied, and a layout template is being used. Couldn't find a decent way to add a test, but the coverage is still 100% :)
Fixes #16