Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when no global context is supplied, no handler context is supplied, and a layout template is being used #17

Merged
merged 1 commit into from Nov 13, 2014

Conversation

@Torsph
Copy link
Contributor

Torsph commented Nov 13, 2014

Fix crash when no global context is supplied, no handler context is supplied, and a layout template is being used. Couldn't find a decent way to add a test, but the coverage is still 100% :)

Fixes #16

@arb arb added this to the 1.2.2 milestone Nov 13, 2014
@arb arb added the bug label Nov 13, 2014
jagoda added a commit to jagoda/vision that referenced this pull request Nov 13, 2014
@arb

This comment has been minimized.

Copy link
Contributor

arb commented Nov 13, 2014

If you recreate the situation described in #16, that should give you a test right? You know the situation you need to create to make this happen.

The fact that coverage is still 100% means that both sides of context || {} are happening, you just need to create a test that forces it to happen.

@jagoda

This comment has been minimized.

Copy link
Contributor

jagoda commented Nov 13, 2014

@Torsph I have created a test case for your reference. Feel free to pull/modify it as you see fit.

@Torsph

This comment has been minimized.

Copy link
Contributor Author

Torsph commented Nov 13, 2014

@jagoda @arb Thanks. Will fix :)

…upplied, and a layout template is being used
@Torsph Torsph force-pushed the Torsph:fix_missing_context_crash branch from 14c8395 to 008c66d Nov 13, 2014
@Torsph

This comment has been minimized.

Copy link
Contributor Author

Torsph commented Nov 13, 2014

@jagoda I just made the test name a bit more specific.

@jagoda

This comment has been minimized.

Copy link
Contributor

jagoda commented Nov 13, 2014

@Torsph cool. Works for me.

arb added a commit that referenced this pull request Nov 13, 2014
Fix crash when no global context is supplied, no handler context is supplied, and a layout template is being used
@arb arb merged commit 8b46557 into hapijs:master Nov 13, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@arb

This comment has been minimized.

Copy link
Contributor

arb commented Nov 13, 2014

Thanks @Torsph and @jagoda.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.