Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Make compilation errors available to extensions. #33
Currently neither template compilation nor rendering occur until
Currently neither template compilation nor rendering occur until after the 'onPreResponse' event. This means that extensions have no way to intercept template related errors. This change moves the compilation step to an earlier point in the request lifecycle so that compilation errors are made available to the 'onPostHandler' and 'onPreResponse' extension points. Rendering still happens after 'onPreResponse' so that the context object can be modified by extensions all the up through the 'onPreResponse' event. Fixes #10.
Looking at the scope of this change, I think you should bump the major version to minimize any potential issues. While the rewrite is to fix what we're calling a bug, this is a lot of code moving around. All the unit tests may pass, but we don't know how this plugin is being used "out there".
As far as actual implementation goes, I'm not familiar enough with this plugin to speak intelligently about it.