Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin attributes. #65

Merged
merged 1 commit into from Nov 4, 2015
Merged

Update plugin attributes. #65

merged 1 commit into from Nov 4, 2015

Conversation

@jagoda
Copy link
Contributor

jagoda commented Oct 28, 2015

In some use cases it may make sense to load vision before any
connections have been configured. Similarly, multiple plugins in an
application may try to load vision. Since vision only deals with
template rendering, it is possible to do both of these if the
'connections' and 'once' attributes are provided in the plugin
attributes.

Resolves #63.

@jagoda jagoda added the feature label Oct 28, 2015
@jagoda jagoda added this to the 3.1.0 milestone Oct 28, 2015
});
});

it('only registers once', function (done) {

This comment has been minimized.

Copy link
@gergoerdosi

gergoerdosi Oct 28, 2015

Contributor

No expect()?

This comment has been minimized.

Copy link
@jagoda

jagoda Oct 28, 2015

Author Contributor

It seemed unnecessary to me since when the plugin registration fails it passes an error to done() which in turn causes the test to fail. I'm fine adding an expect though if this isn't explicit enough.

@jagoda

This comment has been minimized.

Copy link
Contributor Author

jagoda commented Oct 28, 2015

@hueniverse I would appreciate it if you could confirm that I understood this issue correctly.

@jagoda jagoda modified the milestones: 4.0.0, 3.1.0 Nov 1, 2015
@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Nov 3, 2015

Looks good.

@jagoda jagoda force-pushed the jagoda:feat-attributes branch from 26e1960 to 201311e Nov 4, 2015
In some use cases it may make sense to load vision before any
connections have been configured. Similarly, multiple plugins in an
application may try to load vision. Since vision only deals with
template rendering, it is possible to do both of these if the
'connections' and 'once' attributes are provided in the plugin
attributes.

Resolves #63.
@jagoda jagoda force-pushed the jagoda:feat-attributes branch from 201311e to ba74ce7 Nov 4, 2015
jagoda added a commit that referenced this pull request Nov 4, 2015
Update plugin attributes.
@jagoda jagoda merged commit 464048e into hapijs:master Nov 4, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jagoda jagoda deleted the jagoda:feat-attributes branch Nov 4, 2015
@jagoda jagoda self-assigned this Nov 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.