Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass request to global context function when available #81

Merged
merged 1 commit into from Apr 4, 2016

Conversation

@jagoda
Copy link
Contributor

jagoda commented Apr 1, 2016

Resolves #59.

@jagoda jagoda added the feature label Apr 1, 2016
@jagoda jagoda added this to the 4.1.0 milestone Apr 1, 2016
@jagoda

This comment has been minimized.

Copy link
Contributor Author

jagoda commented Apr 1, 2016

@g6123 what do you think? Would this work for you?

@jagoda jagoda force-pushed the jagoda:feat-context branch from 7f6354e to 472962e Apr 4, 2016
@jagoda jagoda force-pushed the jagoda:feat-context branch from 472962e to 5954f0d Apr 4, 2016
@jagoda jagoda merged commit 164a376 into hapijs:master Apr 4, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jagoda jagoda deleted the jagoda:feat-context branch Apr 4, 2016
@@ -484,12 +510,70 @@ describe('render()', () => {
});
});

it('returns a promise when no options or callback given (server)', () => {
it('does not pass the request to the global context function (server)', (done) => {

This comment has been minimized.

Copy link
@wswoodruff

wswoodruff Dec 29, 2017

Contributor

What's the reasoning behind this test? issue #115 asking to have the request object available to the global context when using request.render

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.