Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9.0.0 Release Notes #144

Closed
geek opened this issue Aug 3, 2016 · 1 comment
Assignees
Milestone

Comments

@geek
Copy link
Member

@geek geek commented Aug 3, 2016

Summary

wreck has a bug fix (#142) that changes the existing behavior of requests when using a baseUrl and path together. It will most likely not negatively impact anyone and will not require any changes to existing code.

Breaking Change

When making a request on an instance of wreck that has a baseUrl property set, if the path contains a host and protocol then the path host and protocol will be used instead of the baseUrl host and protocol.

Example to demonstrate this change:

const Wreck = require('wreck');
const wreck = Wreck.defaults({ baseUrl: 'http://google.com' });

wreck.get('http://yahoo.com/', (err, res) => {

    // Before v9.0.0 this would make a request to google.com
    // After v9.0.0 this will request yahoo.com
});

wreck.get('/somepath', (err, res) => {

    // Still requests http://google.com/somepath
});

New Features

When you make a request with a payload that can be serialized by JSON.stringify that is not a stream or buffer, then the object will be serialized and the appropriate content-type header set (if the content-type header isn't already set).

Migration Checklist

  • Search for code that uses a baseUrl
  • If the request includes a path to a different host or protocol than what you want, either change the path or remove the host and protocol from the path.
@geek geek added this to the 9.0.0 milestone Aug 3, 2016
@geek geek self-assigned this Aug 3, 2016
@geek geek closed this Aug 3, 2016
@gdibble

This comment has been minimized.

Copy link

@gdibble gdibble commented Aug 19, 2016

👍 nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.