Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can Wreck parse urls with the WHATWG Url? #238

Closed
WesTyler opened this issue Feb 27, 2019 · 2 comments
Closed

Can Wreck parse urls with the WHATWG Url? #238

WesTyler opened this issue Feb 27, 2019 · 2 comments
Assignees
Labels
Milestone

Comments

@WesTyler
Copy link
Contributor

@WesTyler WesTyler commented Feb 27, 2019

It looks like Wreck is not using the WHATWG Url parser for Node.js here that hapi recently moved to. WHATWG Url is also the default for Node.js beginning in the 11.x release line.

I'll open up a PR in just a few minutes, just wanted to create an issue for tracking.

@WesTyler

This comment has been minimized.

Copy link
Contributor Author

@WesTyler WesTyler commented Feb 27, 2019

Turns out Wreck was using the resulting Url object from Url.parse as a vehicle for additional request options like agent, headers, etc. The Url.URL class does not support those additional fields.

I'm working on trying to implement a strategy for merging the URL instance properties with the currently-expected options in order to maintain the contract with the Wreck events. If that proves unsuccessful this may end up being a breaking change 😬 :(

@geek geek added the feature label Feb 28, 2019
@WesTyler WesTyler mentioned this issue Feb 28, 2019
@geek geek added this to the 14.2.0 milestone Mar 5, 2019
@geek geek self-assigned this Mar 5, 2019
@geek

This comment has been minimized.

Copy link
Member

@geek geek commented Mar 5, 2019

Fixed by #239

@geek geek closed this Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.