Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'abort' event #254

Closed
Bodasia opened this issue Jun 24, 2019 · 0 comments
Closed

'abort' event #254

Bodasia opened this issue Jun 24, 2019 · 0 comments
Assignees
Labels
bug
Milestone

Comments

@Bodasia
Copy link
Contributor

@Bodasia Bodasia commented Jun 24, 2019

For many reasons, node caches and leaves in memory ( for pretty lengthy amount of time ) HTTPRequest instances. Wreck already unsubscribes from events, but it doesn't unsubscribe from 'abort' event, leaving references to finish / callback. This is kind-of okay in most cases ( HTTPRequest's do die after a while ), it might be a problem with large payloads or other memory-hungry situations.
This was only tested with nodejs 8 - future versions might change how they are working with HTTPRequest's objects. #250

@hueniverse hueniverse self-assigned this Sep 18, 2019
@hueniverse hueniverse added the bug label Sep 18, 2019
@hueniverse hueniverse added this to the 15.0.3 milestone Sep 18, 2019
@hueniverse hueniverse closed this Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.