Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "response" Payload #83

Closed
arb opened this issue Apr 24, 2015 · 7 comments
Closed

Change "response" Payload #83

arb opened this issue Apr 24, 2015 · 7 comments
Assignees
Milestone

Comments

@arb
Copy link
Contributor

@arb arb commented Apr 24, 2015

I propose we change the payload we send to "response" handlers to be err, payload and just make payload a single large object rather than the five parameters we are currently passing. Much easier to maintain and won't introduce breaking changes when we need to add more to it.

@geek

This comment has been minimized.

Copy link
Member

@geek geek commented Apr 24, 2015

you mean the response event?

I am fine with (err, details), payload wouldn't be very useful

@geek geek added the request label Apr 24, 2015
@arb

This comment has been minimized.

Copy link
Contributor Author

@arb arb commented Apr 24, 2015

The value send back when we do emit(err,.....) it doesn't matter what we call it, just something that's a big single object rather than a bunch of little arguments. I can see why payload would be confusing though in retrospect 😄

@hueniverse

This comment has been minimized.

Copy link
Member

@hueniverse hueniverse commented May 29, 2015

What line of code specifically?

@arb

This comment has been minimized.

Copy link
Contributor Author

@arb arb commented May 29, 2015

@hueniverse

This comment has been minimized.

Copy link
Member

@hueniverse hueniverse commented May 30, 2015

Oh, the event stuff. I could not care less. I hate using event interfaces. They suck.

@arb

This comment has been minimized.

Copy link
Contributor Author

@arb arb commented Jun 2, 2015

Care to elaborate on that? I'd be interested in hearing about alternate approaches.

@nlf

This comment has been minimized.

Copy link
Member

@nlf nlf commented Mar 21, 2017

nudge nudge @geek is this something you intend to implement? if not, let's close it

@geek geek added breaking changes and removed request labels Mar 21, 2017
@geek geek added this to the 11.0.0 milestone Mar 21, 2017
@geek geek self-assigned this Mar 21, 2017
@geek geek added the feature label Mar 21, 2017
@geek geek closed this in #157 Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.