Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upChange "response" Payload #83
Closed
Comments
This comment has been minimized.
This comment has been minimized.
you mean the response event? I am fine with |
This comment has been minimized.
This comment has been minimized.
The value send back when we do |
This comment has been minimized.
This comment has been minimized.
What line of code specifically? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Oh, the event stuff. I could not care less. I hate using event interfaces. They suck. |
This comment has been minimized.
This comment has been minimized.
Care to elaborate on that? I'd be interested in hearing about alternate approaches. |
This comment has been minimized.
This comment has been minimized.
nudge nudge @geek is this something you intend to implement? if not, let's close it |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I propose we change the payload we send to "response" handlers to be
err, payload
and just makepayload
a single large object rather than the five parameters we are currently passing. Much easier to maintain and won't introduce breaking changes when we need to add more to it.