Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't read redirected URI #91

Closed
kanongil opened this issue Jun 15, 2015 · 2 comments
Closed

Can't read redirected URI #91

kanongil opened this issue Jun 15, 2015 · 2 comments
Labels
Milestone

Comments

@kanongil
Copy link
Member

@kanongil kanongil commented Jun 15, 2015

The current API doesn't allow a user to know which URI that the request might have been redirected to. I need the redirected URI to resolve relative links from the redirected resource.

Another complication, is that I would like to be able to abort() the request at any time. The redirection logic means that the ClientRequest object returned from Wreck.request() will stop working this way once the first redirect is active.

The only simple solution, that can solve both of these issues, is to expose a redirect callback, which is called whenever a redirect request has been performed. A signature like this should do the trick: function (status, location, req) {}.

Let me know if you agree, and I will take a stab at implementing this.

@hueniverse hueniverse added the request label Jun 15, 2015
kanongil added a commit to kanongil/wreck that referenced this issue Jul 3, 2015
@geek geek closed this in #97 Jul 29, 2015
@hueniverse

This comment has been minimized.

Copy link
Member

@hueniverse hueniverse commented Jul 29, 2015

Milestone?

@geek geek added this to the 6.1.0 milestone Jul 30, 2015
@geek

This comment has been minimized.

Copy link
Member

@geek geek commented Jul 30, 2015

@hueniverse my bad, it closed as part of the other merge

@Marsup Marsup added feature and removed request labels Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.