Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass an Error object to Boom.create for #168 #169

Merged
merged 1 commit into from Apr 3, 2017

Conversation

@AdriVanHoudt
Copy link
Contributor

AdriVanHoudt commented Apr 1, 2017

No description provided.

@geek geek added the bug label Apr 2, 2017
@geek geek added this to the 12.0.1 milestone Apr 2, 2017
@geek geek self-assigned this Apr 2, 2017
@geek

This comment has been minimized.

Copy link
Member

geek commented Apr 2, 2017

LGTM

@kanongil see any issues with this?

@kanongil

This comment has been minimized.

Copy link
Member

kanongil commented Apr 2, 2017

I guess it will be more efficient, but doesn't change the stack trace.

@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor Author

AdriVanHoudt commented Apr 2, 2017

yeah I came to the same conclusion

@geek geek added lts and removed bug labels Apr 3, 2017
@geek geek merged commit 06f3b4f into hapijs:master Apr 3, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@AdriVanHoudt AdriVanHoudt deleted the AdriVanHoudt:pass-error-to-boom branch Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.