Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(json): allow numbers in mime fixes #176 #177

Merged
merged 2 commits into from Apr 25, 2017
Merged

fix(json): allow numbers in mime fixes #176 #177

merged 2 commits into from Apr 25, 2017

Conversation

@AdriVanHoudt
Copy link
Contributor

AdriVanHoudt commented Apr 25, 2017

No description provided.

@@ -17,7 +17,7 @@ const Tap = require('./tap');
// Declare internals

const internals = {
jsonRegex: /^application\/[a-z.+-]*json$/,
jsonRegex: /^application\/[a-z0-9.+-]*json$/,

This comment has been minimized.

Copy link
@geek

geek Apr 25, 2017

Member

Maybe
/^application\/([a-z0-9.]*[+-]json|json)$/
to avoid application/blahjson returning true? Likely an edge case, but seems reasonable to prevent

@geek geek self-assigned this Apr 25, 2017
@geek geek added the feature label Apr 25, 2017
@geek geek added this to the 12.1.1 milestone Apr 25, 2017
@geek geek merged commit 04a2d70 into master Apr 25, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@geek geek deleted the AdriVanHoudt-patch-1 branch Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.