Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(request) correct tests to check errors for boom instance #215

Merged
merged 2 commits into from Mar 8, 2018

Conversation

@03byron
Copy link
Contributor

03byron commented Mar 6, 2018

This PR corrects some tests that claim to test for errors being a boom instance but dont actually test it.

@Marsup

This comment has been minimized.

Copy link
Member

Marsup commented Mar 7, 2018

You can likely do the same thing by changing to .to.reject(Boom).

@geek geek self-assigned this Mar 8, 2018
@geek geek added the test label Mar 8, 2018
@geek geek added this to the 14.1.0 milestone Mar 8, 2018
@geek geek merged commit 2f2f3c3 into hapijs:master Mar 8, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@03byron

This comment has been minimized.

Copy link
Contributor Author

03byron commented Mar 8, 2018

Thanks for the hint @Marsup - didnt know about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.