Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for unicode characters in string payloads, closes #20 #23

Merged
merged 1 commit into from Aug 3, 2014

Conversation

@nlf
Copy link
Member

nlf commented Aug 2, 2014

If options.payload is a string, we should use Buffer.byteLength(options.payload) instead of options.payload.length

@hueniverse hueniverse added the bug label Aug 3, 2014
@hueniverse hueniverse added this to the 2.5.4 milestone Aug 3, 2014
@hueniverse hueniverse self-assigned this Aug 3, 2014
hueniverse added a commit that referenced this pull request Aug 3, 2014
allow for unicode characters in string payloads, closes #20
@hueniverse hueniverse merged commit b740b00 into master Aug 3, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@nlf nlf deleted the unicode branch Aug 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.