Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return an empty buffer payload on text content-type rather than `null` #247

Merged
merged 1 commit into from Sep 18, 2019

Conversation

@dominykas
Copy link
Contributor

dominykas commented Apr 5, 2019

Closes #220.

Technically this is a breaking change for those who expect the null for content-type: text/*.

@dominykas dominykas force-pushed the dominykas:empty-txt-to-json branch from 9cd12cb to 5d93e73 Apr 5, 2019
@hueniverse hueniverse self-assigned this Sep 18, 2019
@hueniverse hueniverse added the bug label Sep 18, 2019
@hueniverse hueniverse added this to the 15.0.3 milestone Sep 18, 2019
@hueniverse hueniverse merged commit 85e3947 into hapijs:master Sep 18, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Sep 18, 2019

I don't thing the breaking change is meaningful as this is a bug. But going to label it in case someone get bitten by this...

@dominykas dominykas deleted the dominykas:empty-txt-to-json branch Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.