Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory leak issue #250

Merged
merged 5 commits into from Sep 18, 2019
Merged

memory leak issue #250

merged 5 commits into from Sep 18, 2019

Conversation

@Bodasia
Copy link
Contributor

Bodasia commented Jun 10, 2019

resolved issue with memory leak on abort request

resolved issue with memory leak on abort request
@geek

This comment has been minimized.

Copy link
Member

geek commented Jun 10, 2019

@Bodasia good catch, it might be helpful to add a comment above this line to say a little about its purpose

@geek geek added the bug label Jun 10, 2019
@geek
geek approved these changes Jun 10, 2019
@geek
geek approved these changes Jun 10, 2019
@Bodasia Bodasia mentioned this pull request Jun 24, 2019
@Bodasia

This comment has been minimized.

Copy link
Contributor Author

Bodasia commented Jun 24, 2019

fix space
@Bodasia

This comment has been minimized.

Copy link
Contributor Author

Bodasia commented Jun 24, 2019

@geek Can you help to fix issue in CI

Error: ENOENT: no such file or directory, open '/home/travis/build/hapijs/wreck/hapi'

@geek

This comment has been minimized.

Copy link
Member

geek commented Jun 24, 2019

@Bodasia with help from @cjihrig here is how to fix the issue:

Update the package.json and replace the lint-md entry with the following:

"lint-md": "eslint --config @hapi/eslint-config-hapi --parser-options=ecmaVersion:8 --rule \"strict: 0, eol-last: 0\" --plugin markdown --ext md .",
@Bodasia

This comment has been minimized.

Copy link
Contributor Author

Bodasia commented Jun 26, 2019

@geek thanks

@hueniverse hueniverse added this to the 15.0.3 milestone Sep 18, 2019
@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Sep 18, 2019

Thanks!

@hueniverse hueniverse merged commit cbe1173 into hapijs:master Sep 18, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hueniverse added a commit that referenced this pull request Sep 18, 2019
hueniverse added a commit that referenced this pull request Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.