Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxSockets Support #4

Merged
merged 5 commits into from Mar 12, 2014
Merged

maxSockets Support #4

merged 5 commits into from Mar 12, 2014

Conversation

@jaw187
Copy link

jaw187 commented Feb 25, 2014

Added option for configuring custom maxSockets values for requests.

James Weston added 2 commits Feb 25, 2014
@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Feb 25, 2014

Missing tests to bring coverage back to 100%

@jaw187

This comment has been minimized.

Copy link
Author

jaw187 commented Feb 27, 2014

Tests added.

Also improved check on options.maxSockets to include catch for when options.maxSockets === true since true > 0

@jaw187

This comment has been minimized.

Copy link
Author

jaw187 commented Mar 7, 2014

Realized that creating a separate Agent for each Nipple request would defeat the purpose of connection pooling. Rewrote to add support for accepting an Agent option instead of maxSockets.

@hueniverse hueniverse added this to the 2.3.0 milestone Mar 12, 2014
@hueniverse hueniverse self-assigned this Mar 12, 2014
hueniverse added a commit that referenced this pull request Mar 12, 2014
maxSockets Support
@hueniverse hueniverse merged commit 61bf845 into hapijs:master Mar 12, 2014
1 check failed
1 check failed
default The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.