Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to set secureProtocol to a value. #55

Merged
merged 3 commits into from Sep 15, 2014
Merged

Conversation

@kidtronnix
Copy link
Contributor

kidtronnix commented Sep 11, 2014

Fixed socket hang up problem I was having with wreck and self signed https.

Changes to be committed:
modified: lib/index.js

Closes #56

Fixed socket hang up problem I was having with wreck and self signed https.

 Changes to be committed:
	modified:   lib/index.js
@lloydbenson

This comment has been minimized.

Copy link
Contributor

lloydbenson commented Sep 11, 2014

Assuming @geek wants to support this, you need to add a test so that we are at full code coverage.

@kidtronnix

This comment has been minimized.

Copy link
Contributor Author

kidtronnix commented Sep 11, 2014

Ok will write a test to make sure we have full code coverage.

@@ -67,6 +67,10 @@ exports.request = function (method, url, options, callback, _trace) {
uri.agent = uri.protocol === 'https:' ? exports.agents.https : exports.agents.http;
}

if(options.secureProtocol !== undefined) {

This comment has been minimized.

Copy link
@geek

geek Sep 11, 2014

Member

if (

@geek

This comment has been minimized.

Copy link
Member

geek commented Sep 11, 2014

@smaxwellstewart please also add details about this option to the readme

@geek geek added the feature label Sep 11, 2014
@geek geek self-assigned this Sep 11, 2014
@geek geek added this to the 5.0.2 milestone Sep 11, 2014
@geek geek mentioned this pull request Sep 11, 2014
@kidtronnix

This comment has been minimized.

Copy link
Contributor Author

kidtronnix commented Sep 13, 2014

Will do.

On 11 September 2014 17:03, Wyatt Preul notifications@github.com wrote:

@smaxwellstewart https://github.com/smaxwellstewart please also add
details about this option to the readme


Reply to this email directly or view it on GitHub
#55 (comment).

@geek

This comment has been minimized.

Copy link
Member

geek commented Sep 14, 2014

Please also add a test if you don't mind. Thanks for the help.

@kidtronnix

This comment has been minimized.

Copy link
Contributor Author

kidtronnix commented Sep 15, 2014

@geek As promised here is the enhancement with test and documentation. Thanks so much for making such a rad tool, excited that I can help enhance it.

geek added a commit that referenced this pull request Sep 15, 2014
Added ability to set secureProtocol to a value.
@geek geek merged commit 6567d27 into hapijs:master Sep 15, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.