Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded 'smart' and 'force' modes to json option. #70
+89
−18
Conversation
arb
changed the title
lib/index.js
Outdated
| return callback(null, buffer); | ||
| } | ||
| var result; | ||
| var mode = (options.json === true || options.json.toLowerCase() === 'smart') ? 'smart' : 'force'; |
This comment has been minimized.
This comment has been minimized.
geek
Jan 8, 2015
Member
doesn't seem like you need this line, could check options.json === 'force' directly on line 232
This comment has been minimized.
This comment has been minimized.
| err: null | ||
| }; | ||
| try { | ||
| var json = JSON.parse(buffer.toString()); |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
arb
Jan 9, 2015
Author
Contributor
I think it reads a little easier as is. It's obvious that if the parse fails, json will be null. I can change it though if need be.
This comment has been minimized.
This comment has been minimized.
legomind
commented
Jan 9, 2015
|
Sweet. |
geek
added a commit
that referenced
this pull request
Feb 13, 2015
Added 'smart' and 'force' modes to json option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
arb commentedJan 8, 2015
Trumps #68 because that will still look at the content-type header even in 'force' mode. My change does not and tries to parse regardless of the header. Which was the goal of #67 I believe.