Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added uri to event payloads. #81

Merged
merged 2 commits into from Apr 23, 2015
Merged

Added uri to event payloads. #81

merged 2 commits into from Apr 23, 2015

Conversation

@arb
Copy link
Contributor

arb commented Apr 21, 2015

Unless I'm completely missing it somewhere, there isn't a way to get the full URL requested with Wreck in the "response" event. Added uri object to the "response" payload. This will let you log more detailed information about the upstream request.

Related to hapijs/good#334

@arb arb added the feature label Apr 21, 2015
Fixed up some formatting.
@geek geek self-assigned this Apr 22, 2015
@geek

This comment has been minimized.

Copy link
Member

geek commented Apr 22, 2015

This is a workaround to the problem... the entire request object is sent on the event, we just need to read the correct properties on the ClientRequest

@geek geek closed this Apr 22, 2015
@@ -100,7 +100,7 @@ internals.Client.prototype.request = function (method, url, options, callback, _
req.removeListener('error', onError);
req.on('error', Hoek.ignore);
clearTimeout(timeoutId);
self.emit('response', err, req, res, start);
self.emit('response', err, req, res, start, uri);

This comment has been minimized.

Copy link
@cjihrig

cjihrig Apr 22, 2015

Contributor

It might be worth Wreck storing some of the data that isn't fully available later on, such as the URL.

@arb arb reopened this Apr 22, 2015
@geek geek added this to the 5.4.1 milestone Apr 23, 2015
geek added a commit that referenced this pull request Apr 23, 2015
Added uri to event payloads.
@geek geek merged commit e62275e into hapijs:master Apr 23, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@arb arb deleted the arb:event-data branch Apr 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.