Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upcoverage to 100% with Lab v3.0 #9
Merged
+147
−13
Conversation
| @@ -278,7 +273,9 @@ internals.Recorder = function (options) { | |||
|
|
|||
| Stream.Writable.call(this); | |||
|
|
|||
| this.settings = Hoek.clone(options || {}); | |||
| Hoek.assert(options); // called internally - should not be null | |||
This comment has been minimized.
This comment has been minimized.
hueniverse
Apr 5, 2014
Member
Assert must have a message. Also we put input validation code at the top of the function.
| var Stream = require('stream'); | ||
|
|
||
| it('handle empty payload', function (done) { | ||
| var stream = Nipple.toReadableStream(/* empty */); |
This comment has been minimized.
This comment has been minimized.
hueniverse
added a commit
that referenced
this pull request
Apr 11, 2014
coverage to 100% with Lab v3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
biant commentedApr 4, 2014
No description provided.