Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage to 100% with Lab v3.0 #9

Merged
merged 1 commit into from Apr 11, 2014
Merged

coverage to 100% with Lab v3.0 #9

merged 1 commit into from Apr 11, 2014

Conversation

@biant
Copy link

biant commented Apr 4, 2014

No description provided.

b1tan
@@ -278,7 +273,9 @@ internals.Recorder = function (options) {

Stream.Writable.call(this);

this.settings = Hoek.clone(options || {});
Hoek.assert(options); // called internally - should not be null

This comment has been minimized.

Copy link
@hueniverse

hueniverse Apr 5, 2014

Member

Assert must have a message. Also we put input validation code at the top of the function.

var Stream = require('stream');

it('handle empty payload', function (done) {
var stream = Nipple.toReadableStream(/* empty */);

This comment has been minimized.

Copy link
@hueniverse

hueniverse Apr 5, 2014

Member

empty line after function declaration. also in a few other places.

@hueniverse hueniverse added the test label Apr 5, 2014
@hueniverse hueniverse added this to the 2.5.0 milestone Apr 11, 2014
hueniverse added a commit that referenced this pull request Apr 11, 2014
coverage to 100% with Lab v3.0
@hueniverse hueniverse merged commit 51626ae into hapijs:master Apr 11, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
hueniverse added a commit that referenced this pull request Apr 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.