Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing options when redirecting #93

Merged
merged 1 commit into from Jun 30, 2015
Merged

Conversation

@kanongil
Copy link
Member

kanongil commented Jun 22, 2015

The rejectUnauthorized, agent, and secureProtocol options were discarded on redirects.

This is fixed by copying all options and ensuring one-time options are removed once applied.

I have added tests for the rejectUnauthorized and agent options but I did not find a way to test the secureProtocol option.

Note that this is actually a security fix, as the secureProtocol option is currently ignored on any redirected requests.

The rejectUnauthorized, agent, and secureProtocol options were discarded on redirects.
This is fixed by copying all options and ensuring one-time options are removed once applied.
@kanongil

This comment has been minimized.

Copy link
Member Author

kanongil commented Jun 22, 2015

FYI, the travis build failures are not related to my patch.

@geek geek added this to the 5.6.1 milestone Jun 30, 2015
@geek geek self-assigned this Jun 30, 2015
geek added a commit that referenced this pull request Jun 30, 2015
Fix missing options when redirecting
@geek geek merged commit 67a5190 into hapijs:master Jun 30, 2015
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.