Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete a specific user's session #123

Closed
tomnocon opened this issue Sep 19, 2018 · 4 comments
Closed

Delete a specific user's session #123

tomnocon opened this issue Sep 19, 2018 · 4 comments
Assignees
Labels
Milestone

Comments

@tomnocon
Copy link
Contributor

@tomnocon tomnocon commented Sep 19, 2018

I'm trying to implement the Back-Channel Logout from the OpenId Connect specification. There is a case when the OpenID Provider (OP) want to delete session in the Relying Party (RP) for a specific user. Is it possible to delete a specific user's session?

To accomplish the above requirement, a method is needed for deleting a specific session. I've found a workaround solution but I think that it is not a good idea.

 const cache = server._core.caches.get('_default');
 cache.client.drop({id: sessionId, segment: '!yar'})

I would be good to do it directly in the yar object.

@tomnocon tomnocon changed the title Delete specific user's session Delete a specific user's session Sep 19, 2018
@hueniverse hueniverse added request and removed help wanted labels Sep 24, 2018
@hueniverse

This comment has been minimized.

Copy link
Member

@hueniverse hueniverse commented Sep 24, 2018

I'll take a PR. I assume in your use case, you don't have an active request for the user, only a server reference and the session id? If that's the case, this should be a server-level decoration and look like server.yar.revoke(id).

@tomnocon

This comment has been minimized.

Copy link
Contributor Author

@tomnocon tomnocon commented Sep 25, 2018

Yes, that's exactly what I mean. I'll create a PR.

@tomnocon

This comment has been minimized.

Copy link
Contributor Author

@tomnocon tomnocon commented Sep 26, 2018

Hello, @hueniverse. Can you create a branch from the v8.1.2 tag? I've also implemented this feature for the previous version, so I'll be able to create a pull request. Thanks!

@dchrzascik

This comment has been minimized.

Copy link

@dchrzascik dchrzascik commented Oct 3, 2018

Hi @hueniverse, would it be possible to do as @tomnocon suggests? Our ticket depends on resultion of this issue and we would love to see it merged and closed. Thanks!

@hueniverse hueniverse added this to the 9.0.3 milestone Nov 3, 2018
@hueniverse hueniverse added feature and removed help wanted labels Nov 3, 2018
@hueniverse hueniverse self-assigned this Nov 3, 2018
@hueniverse hueniverse closed this Nov 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.