Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yar doesn't handle the session cookie multiple times correctly. #124

Closed
SimonSchick opened this issue Sep 23, 2018 · 2 comments
Closed

Yar doesn't handle the session cookie multiple times correctly. #124

SimonSchick opened this issue Sep 23, 2018 · 2 comments
Assignees
Labels
bug
Milestone

Comments

@SimonSchick
Copy link
Contributor

@SimonSchick SimonSchick commented Sep 23, 2018

Apparently https://github.com/hapijs/yar/blob/master/lib/index.js#L85 request.state[settings.name] can be an array, not just an object, yar should probably handle that.

I am not sure what yar should do, probably revoke the cookie(s) as it's technically invalid or just use the first valid one.

I know this isn't exactly intended behaviour but this came up when a colleague was debugging some of our endpoints with postman which for whatever reason duplicated cookies.

@SimonSchick

This comment has been minimized.

Copy link
Contributor Author

@SimonSchick SimonSchick commented Sep 23, 2018

@hueniverse hueniverse self-assigned this Sep 24, 2018
@hueniverse hueniverse added the bug label Sep 24, 2018
@hueniverse hueniverse added this to the 9.0.2 milestone Sep 24, 2018
@SimonSchick

This comment has been minimized.

Copy link
Contributor Author

@SimonSchick SimonSchick commented Sep 24, 2018

That didn't take long 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.