Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errorhandling after cookie password changes #41

Closed
hochitom opened this issue Jul 3, 2014 · 4 comments
Closed

errorhandling after cookie password changes #41

hochitom opened this issue Jul 3, 2014 · 4 comments
Assignees
Labels
bug
Milestone

Comments

@hochitom
Copy link

@hochitom hochitom commented Jul 3, 2014

i can't describe it properly at the moment, but there is a short description to reproduce the error:
setup yar and open your browser. when you have a cookie set, change the cookie password and try to refresh the page.

the error is in yar/lib/index.js on line 181 (cannot read property _isModified of undefined)

edit:
there should be a proper errorhandling if the passwort gets changed. otherwise the app crashes and the only way is to clear the cookies in the browser. and because i'm not able to communicate that at that moment, this is (in my opinion) a really bad behaviour.

@hochitom hochitom changed the title error after cookie password changes errorhandling after cookie password changes Jul 10, 2014
@hueniverse

This comment has been minimized.

Copy link
Member

@hueniverse hueniverse commented Jul 16, 2014

I think this was fixed in master. Can you retry?

@hueniverse hueniverse closed this Jul 16, 2014
@hueniverse hueniverse added the bug label Jul 16, 2014
@hueniverse hueniverse added this to the 2.4.0 milestone Jul 16, 2014
@hueniverse hueniverse self-assigned this Jul 16, 2014
@hochitom

This comment has been minimized.

Copy link
Author

@hochitom hochitom commented Jul 18, 2014

yeah, now i get a error message.

but i think this is not proper solution thoug. in my opinion it would be better if you generate a complete new session. or is it possible to handle that error in hapi?

@hueniverse

This comment has been minimized.

Copy link
Member

@hueniverse hueniverse commented Jul 19, 2014

Try setting cookieOptions.clearInvalid to true.

@hochitom

This comment has been minimized.

Copy link
Author

@hochitom hochitom commented Jul 21, 2014

nope. changed nothing.

edit: works fine now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.