Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to hapi 3.x #28

Closed
wants to merge 1 commit into from
Closed

Update to hapi 3.x #28

wants to merge 1 commit into from

Conversation

@tschaub
Copy link

tschaub commented Mar 18, 2014

This is really a "pull request as question."

I'm interested in using the hapi 3.0.0 release, but can't find information on what else does/doesn't work with it in the Spumko ecosystem. For yar, the tests pass with hapi@3.0.0. Does this mean the two can be used together?

I've got the same question about travelogue (where tests also pass with hapi@3.0.0). Thanks for any tips. Ok by me if this gets closed and the answer is "don't use hapi 3 yet."

@tschaub

This comment has been minimized.

Copy link
Author

tschaub commented Mar 18, 2014

I should say that make test passes, but I'm not seeing 100% coverage when running make test-cov (or npm test). I'm getting the same failures on master though - curious why I don't see the same on Travis (though I'm also getting newer versions of multiparty, lab, optimist, catbox, hoek, joi, boom, iron, and nipple than the last successful run, so it could be anywhere).

@chrisspiegl

This comment has been minimized.

Copy link

chrisspiegl commented Mar 19, 2014

+1

@hueniverse hueniverse added this to the 2.0.0 milestone Mar 20, 2014
@hueniverse hueniverse self-assigned this Mar 20, 2014
@tschaub tschaub deleted the tschaub:hapi-3 branch Mar 20, 2014
@tschaub

This comment has been minimized.

Copy link
Author

tschaub commented Mar 20, 2014

Thanks @hueniverse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.