Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Hapi 4.x #32

Merged
merged 3 commits into from Apr 9, 2014
Merged

Upgrade to Hapi 4.x #32

merged 3 commits into from Apr 9, 2014

Conversation

@ldesplat
Copy link
Contributor

ldesplat commented Apr 8, 2014

  • Hoek is needed instead of hapi.utils
  • I did run make test which passed and make test-cov
    lib/index.js missing coverage on line(s): 69, 118, 122, 159, 194, 202
    Code coverage below threshold: 96.53 < 100
  • Would most likely need to upgrade to lab 3 but I got issues so I left it alone for now.
ldesplat added 2 commits Apr 8, 2014
- Hoek is needed instead of hapi.utils
@ldesplat

This comment has been minimized.

Copy link
Contributor Author

ldesplat commented Apr 8, 2014

Upgrade to Lab 3.x and test-cov:
Coverage: 99.42%

lib/index.js missing coverage on line(s): 69
Code coverage below threshold: 99.42 < 100

Wasn't sure how to drive line 69.

@ldesplat

This comment has been minimized.

Copy link
Contributor Author

ldesplat commented Apr 8, 2014

I just had to add a test which waits for the cache to expire.

@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Apr 9, 2014

You sir, are awesome.

hueniverse added a commit that referenced this pull request Apr 9, 2014
Upgrade to Hapi 4.x
@hueniverse hueniverse merged commit c38991a into hapijs:master Apr 9, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@hueniverse hueniverse added this to the 2.1.0 milestone Apr 9, 2014
@hueniverse hueniverse self-assigned this Apr 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.