Check that a "replication" connection is possible before pg_rewind. #665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelteF
approved these changes
Apr 19, 2021
If the upstream server isn't ready for a replication connection being made, then both pg_rewind and then pg_basebackup will fail. The current code would attribute the error to pg_rewind itself though, and continue with a full base backup, where it might be possible to connect and rewind later.
DimCitus
force-pushed
the
fix/check-replication-connection-before-pg_rewind
branch
from
eb2156b to
b13c933
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the upstream server isn't ready for a replication connection being made,
then both pg_rewind and then pg_basebackup will fail. The current code would
attribute the error to pg_rewind itself though, and continue with a full
base backup, where it might be possible to connect and rewind later.