Use sysctl(3) on BSD #733
Merged
Use sysctl(3) on BSD #733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimCitus
reviewed
Jun 17, 2021
DimCitus
added
enhancement
sysctlbyname(3) is a convenience wrapper for sysctl(3) that is implemented on FreeBSD and MacOS, but not on OpenBSD. Include sys/param.h to ensure that BSD is defined. Tests on OpenBSD: - make check - initialize a monitor node and 2 nodes - perform failover Tests on MacOS: - make check
|
Hi @eradman ; I just had a try of your branch locally on my laptop, and it fails to detect the amount of RAM properly when using your current code. I suppose the old API needs to use another MIB? - 12:23:02 43377 DEBUG pgtuning.c:85: Detected 12 CPUs and 16 GB total RAM on this server
+ 12:22:26 42248 DEBUG pgtuning.c:85: Detected 12 CPUs and 2048 MB total RAM on this serverThat's the diff when running the following command once in the master's branch, then once in your PR branch: |
Tested on - MacOS 11.4 - FreeBSD 11.4 - OpenBSD 6.9 PG_AUTOCTL_DEBUG=1 pg_autoctl do pgsetup tune --pgdata /tmp -vv
eradman
commented
Jun 18, 2021
|
I just tried it with a macOS and confirm this now works, and I think we're good with the code the way you've submitted it. I trust you have validated OpenBSD and FreeBSD variants, and intend to merge after Travis confirmed a test run. |
DimCitus
approved these changes
Jun 28, 2021
|
Thanks for your contribution @eradman ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sysctlbyname(3) is a convenience wrapper for sysctl(3) that is implemented on FreeBSD and MacOS, but not on OpenBSD.
Include
sys/param.hto ensure that BSD is defined.