Make sure to disable sync rep when initializing a primary. #801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The step to reach the SINGLE state could be done from a pre-existing PGDATA, such as taken from a backup tool. In that case, the postgresql.auto.conf might have been installed with a setting that enables synchronous replication. Trouble is, we're initializing the first node in the system, and when we reach the SINGLE state any setup for sync-rep does not make sense, we know we don't have any secondary available.
DimCitus
added
bug
JelteF
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The step to reach the SINGLE state could be done from a pre-existing PGDATA,
such as taken from a backup tool. In that case, the postgresql.auto.conf
might have been installed with a setting that enables synchronous
replication.
Trouble is, we're initializing the first node in the system, and when we
reach the SINGLE state any setup for sync-rep does not make sense, we know
we don't have any secondary available.
Fixes #721