Skip to content

Conversation

@amontalban
Copy link
Contributor

This PR allows configuring the maximum-backup-rate setting when running pg_autoctl create postgres.

Fixes #780

@ghost
Copy link

ghost commented Sep 22, 2021

CLA assistant check
All CLA requirements met.

Copy link
Collaborator

@DimCitus DimCitus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @amontalban ! Looks good to me, mostly, apart from a very minor detail that we still want to fix before merging. Could you add a commit to that effect in your branch?

@DimCitus DimCitus added enhancement New feature or request good first issue Good for newcomers Size: S Effort Estimate: Small user experience labels Sep 23, 2021
@DimCitus DimCitus added this to the Sprint 2021 W37 W38 milestone Sep 23, 2021
@DimCitus
Copy link
Collaborator

It's now failing the make indent checks. If you can, check out our https://github.com/citusdata/pg_auto_failover/blob/master/CONTRIBUTING.md guidelines and then do make indent and push the new version of your PR, otherwise I'm going to look into doing that myself (but I'm not sure if I'm allowed to push to your branch).

@amontalban
Copy link
Contributor Author

It's now failing the make indent checks. If you can, check out our https://github.com/citusdata/pg_auto_failover/blob/master/CONTRIBUTING.md guidelines and then do make indent and push the new version of your PR, otherwise I'm going to look into doing that myself (but I'm not sure if I'm allowed to push to your branch).

Sorry @DimCitus, I tried that before in my macOS but the Makefile was failing. I got it working and I think it should pass now.

@DimCitus DimCitus merged commit 87acba1 into hapostgres:master Sep 24, 2021
@DimCitus
Copy link
Collaborator

Thanks for your work @amontalban ; both the bug report and now the bug fix, and welcome to the pg_auto_failover contributors team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request good first issue Good for newcomers Size: S Effort Estimate: Small user experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't configure replication.maximum_backup_rate before pg_autoctl create postgres

2 participants