Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop no-op:ing cancelAnimationFrame #92

Merged
merged 1 commit into from Aug 8, 2019

Conversation

@trotzig
Copy link
Contributor

commented Aug 8, 2019

This behavior is leading to unexpected and unwanted behavior where a
component calling cancelAnimationFrame on unmounting could lead to
issues in jsdom where the document is no longer defined.

Stop no-op:ing cancelAnimationFrame
This behavior is leading to unexpected and unwanted behavior where a
component calling cancelAnimationFrame on unmounting could lead to
issues in jsdom where the document is no longer defined.

@trotzig trotzig merged commit 4ebbbd4 into master Aug 8, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@trotzig trotzig deleted the cancel-animation-frame branch Aug 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.