Add DTS support to ld-process-efm #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@DreckSoft tested ld-process-efm with several DTS LaserDiscs, and found that while some decode as with PCM audio, others use a different F3 Sync 0 value. This option adjusts the behaviour of EfmToF3Frames accordingly. It also disables error concealment, defaulting to error passthrough instead.
atsampson
added
enhancement
ld-decode-tools
|
I've updated the ld-process-efm wiki page to match this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on @DreckSoft's work in #527. It adds a
--dtsoption to accept the alternative Sync 0 value that some DTS LaserDiscs use. Since audio error concealment doesn't make sense for DTS, it also changes the default error treatment when the option is used (and checks that you haven't specified multiple treatment options).It's been tested on clips from the following DTS discs:
--dts --time--dts --timeFixes #527.
Note to self: will need to add the new option, and some advice on using it, to the wiki.