New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use modern TLS API for the client #1678

Closed
typingArtist opened this Issue Oct 20, 2016 · 0 comments

Comments

1 participant
@typingArtist
Collaborator

typingArtist commented Oct 20, 2016

Now that the server utilizes the modern tls.TLSSocket() API instead of the deprecated tls.createSecurePair(), the client code should upgrade to the modern API as well.

typingArtist added a commit to typingArtist/Haraka that referenced this issue Oct 20, 2016

typingArtist added a commit to typingArtist/Haraka that referenced this issue Oct 20, 2016

typingArtist added a commit to typingArtist/Haraka that referenced this issue Oct 20, 2016

@msimerson msimerson closed this in #1682 Oct 25, 2016

msimerson added a commit that referenced this issue Oct 25, 2016

use tls.connect for client (#1682)
* haraka/Haraka#1678 use tls.connect instead of createSecurePair

* take key/cert configuration option from tls.ini

* take key/cert configuration option from tls.ini, servername still missing

* avoid unhandled exception due to multiple error emits

* fix linting errors

* removed debug output, added hostname for SNI support

@msimerson msimerson added this to Done in tls-revamp Feb 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment