Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pass notes to send_email #1295

Merged
merged 2 commits into from Jan 15, 2016
Merged

Allow pass notes to send_email #1295

merged 2 commits into from Jan 15, 2016

Conversation

ricardopolo
Copy link
Contributor

When you create a new email using send_email() it creates a brand new transaction.
If you need some information in that transaction like notes filled in another hooks you cannot access to them.

This PR allows to pass a new option the send_email() to preserve the notes. It just adds another option to the options object that send_email() already receives.

Includes updated docs.
Fixes #1293

@codecov-io
Copy link

Current coverage is 36.98%

Merging #1295 into master will decrease coverage by -0.06% as of fa18956

@@            master   #1295   diff @@
======================================
  Files           31      31       
  Stmts         5750    5753     +3
  Branches      1313    1315     +2
  Methods          0       0       
======================================
- Hit           2130    2128     -2
  Partial        225     225       
- Missed        3395    3400     +5

Review entire Coverage Diff as of fa18956

Powered by Codecov. Updated on successful CI builds.

@msimerson
Copy link
Member

+1

Absent any further discussion (here or in #1293), I'll merge this after 2015-01-21.

@smfreegard
Copy link
Collaborator

+1 - seems sensible. I meant to merge it the other day, but forgot.

msimerson added a commit that referenced this pull request Jan 15, 2016
Allow pass notes to send_email
@msimerson msimerson merged commit 80f44ba into haraka:master Jan 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants