New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spf: context=myself fixes #1528

Merged
merged 2 commits into from Jun 29, 2016

Conversation

Projects
None yet
2 participants
@smfreegard
Collaborator

smfreegard commented Jun 29, 2016

Fixes #1329

Changes proposed in this pull request:

  • Display the IP used for lookup in the SPF results
  • Always check the connected IP first and only check the public IP is the result !== Pass. This is because a relay might be sending mail from a non-local domain, currently this scenario would return an incorrect SPF result. This gracefully handles those cases and handles better the case when the public_ip cannot be determined.

@msimerson msimerson merged commit 2d3ca08 into haraka:master Jun 29, 2016

2 checks passed

codecov/project 36.14% (+0.00%) compared to b726987
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@msimerson msimerson referenced this pull request Jan 8, 2017

Merged

spf fix for relaying & context=myself #1759

1 of 1 task complete

msimerson added a commit that referenced this pull request Jan 10, 2017

spf fix for relaying & context=myself (#1759)
* spf fix for relaying & context=myself

which has been broken since #1528

the money shot is the line: spf = new SPF();

* overload log_debug, to tame the test output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment