Support '+' wildcard in aliases plugin #1531

Merged
merged 2 commits into from Jul 3, 2016

Conversation

Projects
None yet
3 participants
@gramakri
Collaborator

gramakri commented Jul 1, 2016

Changes proposed in this pull request:

  • Support for '+' in wildcard notation
  • Make wildcard notation work when host is provided

Checklist:

  • [X ] docs updated
  • [ X] tests updated

gramakri added some commits Jul 1, 2016

Support + as a wildcard in the aliases plugin
It is common to use '+' as a subaddress separator. With a '+'
based scheme, the aliases plugin now splits out the user part
from the details part (see rfc3598 for terminology) and aliases
the user part as defined in the rules.

Prior to this change, only '-' was supported as a subaddress separator.
Make wildcard notation work when host is provided
Currently, test+foo@example.com matches an alias rule "test". However,
it does not match an alias rule "test@example.com".

@gramakri gramakri changed the title from Aliases subaddress to Support '+' wildcard in aliases plugin Jul 1, 2016

@msimerson

This comment has been minimized.

Show comment
Hide comment
@msimerson

msimerson Jul 1, 2016

Member

LGTM.

Thanks for the contribution!

Member

msimerson commented Jul 1, 2016

LGTM.

Thanks for the contribution!

@darkpixel

This comment has been minimized.

Show comment
Hide comment
@darkpixel

darkpixel Jul 2, 2016

Collaborator

Looks good. Nice work!

Collaborator

darkpixel commented Jul 2, 2016

Looks good. Nice work!

@msimerson msimerson merged commit f201bf5 into haraka:master Jul 3, 2016

2 checks passed

codecov/project 36.14% (+0.00%) compared to 2d3ca08
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment