New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUTH PLAIN splitted into two lines #1550

Merged
merged 3 commits into from Aug 18, 2016

Conversation

Projects
None yet
2 participants
@swerter
Contributor

swerter commented Jul 26, 2016

Fixes #1366 .

Changes proposed in this pull request:

  • AUTH PLAIN divided in two lines: Server should respond with 334 code.

Checklist:

  • tests updated

Now also additional email clients can connect to Haraka, such as Gnome geary.

swerter added some commits Jul 26, 2016

Bugfix for #1366
According to RFC-4954, auth plain can also be split into two
lines. After the first line the server should respond with 334 and an
empty space.
Auth plain in two lines (#1366).
According to RFC-4954, auth plain can also be split into two
lines. After the first line the server should respond with 334 and an
empty space.
@baudehlo

This comment has been minimized.

Show comment
Hide comment
@baudehlo

baudehlo Jul 26, 2016

Collaborator

For some reason Travis-CI doesn't acknowledge this PR. So I'm going to do this to try and fix it:

http://stackoverflow.com/questions/19589260/force-travis-to-build-a-specific-pull-request-or-commit-sha-that-it-missed

Collaborator

baudehlo commented Jul 26, 2016

For some reason Travis-CI doesn't acknowledge this PR. So I'm going to do this to try and fix it:

http://stackoverflow.com/questions/19589260/force-travis-to-build-a-specific-pull-request-or-commit-sha-that-it-missed

@baudehlo baudehlo closed this Jul 26, 2016

@baudehlo baudehlo reopened this Jul 26, 2016

@baudehlo

This comment has been minimized.

Show comment
Hide comment
@baudehlo

baudehlo Jul 26, 2016

Collaborator

LGTM. +1

Collaborator

baudehlo commented Jul 26, 2016

LGTM. +1

@baudehlo baudehlo merged commit 0b1762f into haraka:master Aug 18, 2016

1 of 2 checks passed

codecov/project 36.11% (-0.02%) compared to fd0cb3b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment