New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call next() at stream end #1566

Merged
merged 1 commit into from Aug 18, 2016

Conversation

Projects
None yet
2 participants
@baudehlo
Collaborator

baudehlo commented Aug 16, 2016

Fixes #1553

Changes proposed in this pull request:

  • Call next() in the callback, not at stream end.
Matt Sergeant
@msimerson

This comment has been minimized.

Show comment
Hide comment
@msimerson

msimerson Aug 17, 2016

Member

LGTM.

Member

msimerson commented Aug 17, 2016

LGTM.

@baudehlo baudehlo merged commit 99f7758 into master Aug 18, 2016

3 checks passed

codecov/project 36.03% (+0.00%) compared to d059281
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@msimerson msimerson deleted the dkim_next_toosoon branch Aug 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment