Advanced pool #1603

Merged
merged 5 commits into from Sep 23, 2016

Conversation

Projects
None yet
3 participants
@baudehlo
Collaborator

baudehlo commented Sep 20, 2016

Fixes #1576 and possibly others

Changes proposed in this pull request:

  • Mostly belt and braces around the pool code
  • There still appears to be an issue with the pool getting locked up, but I'll continue working on that in another branch

Checklist:

  • docs updated
  • tests updated
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Sep 20, 2016

Current coverage is 35.85% (diff: 12.50%)

Merging #1603 into master will increase coverage by 0.01%

@@             master      #1603   diff @@
==========================================
  Files            26         26          
  Lines          6521       6540    +19   
  Methods         847        849     +2   
  Messages          0          0          
  Branches       1698       1703     +5   
==========================================
+ Hits           2337       2345     +8   
- Misses         4184       4195    +11   
  Partials          0          0          

Powered by Codecov. Last update ca36e90...c456a80

codecov-io commented Sep 20, 2016

Current coverage is 35.85% (diff: 12.50%)

Merging #1603 into master will increase coverage by 0.01%

@@             master      #1603   diff @@
==========================================
  Files            26         26          
  Lines          6521       6540    +19   
  Methods         847        849     +2   
  Messages          0          0          
  Branches       1698       1703     +5   
==========================================
+ Hits           2337       2345     +8   
- Misses         4184       4195    +11   
  Partials          0          0          

Powered by Codecov. Last update ca36e90...c456a80

@@ -1492,7 +1514,12 @@ HMailItem.prototype.try_deliver_host_on_socket = function (mx, host, port, socke
return send_command('MAIL', 'FROM:' + self.todo.mail_from);
};
+ var fp_called = false;

This comment has been minimized.

@msimerson

msimerson Sep 21, 2016

Member

I worry about this value getting toggled to true and then remaining true forever. Does outbound spawn and destroy instances, or run and run and run?

@msimerson

msimerson Sep 21, 2016

Member

I worry about this value getting toggled to true and then remaining true forever. Does outbound spawn and destroy instances, or run and run and run?

This comment has been minimized.

@baudehlo

baudehlo Sep 23, 2016

Collaborator

It's to ensure that finish_processing_mail doesn't get called twice. It's standard practise to use a closure like this.

@baudehlo

baudehlo Sep 23, 2016

Collaborator

It's to ensure that finish_processing_mail doesn't get called twice. It's standard practise to use a closure like this.

@baudehlo baudehlo merged commit 4ae5bab into master Sep 23, 2016

3 of 4 checks passed

codecov/patch 12.50% of diff hit (target 35.83%)
Details
codecov/project 35.85% (+0.01%) compared to ca36e90
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@msimerson msimerson deleted the advanced_pool branch Sep 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment