New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning undefined instead of piping destination #1610

Merged
merged 1 commit into from Sep 26, 2016

Conversation

Projects
None yet
2 participants
@thihara
Contributor

thihara commented Sep 26, 2016

Fixes message stream piping issue.

When trying to pipe the message stream into a transforming stream (gzip in my case) the returning value is undefined.

This is because the short circuiting return statement lacks the necessary return value.

Returning undefined instead of piping destination
When trying to pipe the message stream into a transforming stream (gzip in my case) the returning value is undefined.

This is because the short circuiting return statement lacks the necessary return value.
@msimerson

This comment has been minimized.

Show comment
Hide comment
@msimerson
Member

msimerson commented Sep 26, 2016

thanks @thihara

@msimerson msimerson merged commit 372d31c into haraka:master Sep 26, 2016

3 checks passed

codecov/patch 100% of diff hit (target 35.86%)
Details
codecov/project 35.86% (+0.00%) compared to d439407
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@msimerson msimerson added the Bug Fix label Sep 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment