New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't do a normal release on errors #1615

Merged
merged 2 commits into from Sep 29, 2016

Conversation

Projects
None yet
2 participants
@baudehlo
Collaborator

baudehlo commented Sep 27, 2016

This might improve outbound pool issues but it needs live testing as replicating them seems to be impossible.

Matt Sergeant and others added some commits Sep 27, 2016

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Sep 29, 2016

Current coverage is 35.44% (diff: 11.11%)

Merging #1615 into master will decrease coverage by 0.41%

@@             master      #1615   diff @@
==========================================
  Files            26         26          
  Lines          6542       6763   +221   
  Methods         849        902    +53   
  Messages          0          0          
  Branches       1703       1861   +158   
==========================================
+ Hits           2346       2397    +51   
- Misses         4196       4366   +170   
  Partials          0          0          

Powered by Codecov. Last update e16e710...f086f48

codecov-io commented Sep 29, 2016

Current coverage is 35.44% (diff: 11.11%)

Merging #1615 into master will decrease coverage by 0.41%

@@             master      #1615   diff @@
==========================================
  Files            26         26          
  Lines          6542       6763   +221   
  Methods         849        902    +53   
  Messages          0          0          
  Branches       1703       1861   +158   
==========================================
+ Hits           2346       2397    +51   
- Misses         4196       4366   +170   
  Partials          0          0          

Powered by Codecov. Last update e16e710...f086f48

@baudehlo baudehlo merged commit 6c98e4e into master Sep 29, 2016

2 of 4 checks passed

codecov/patch 11.11% of diff hit (target 35.86%)
Details
codecov/project 35.44% (-0.42%) compared to e16e710
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@baudehlo baudehlo deleted the release_error_handling branch Sep 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment