New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rspamd plugin: Fix spambar for negative scores #1630

Merged
merged 4 commits into from Oct 3, 2016

Conversation

Projects
None yet
3 participants
@fatalbanana
Contributor

fatalbanana commented Oct 3, 2016

Fixes a warning about an unused variable that points at a bug: negative scores weren't processed correctly.

Also avoid adding an empty spambar when score is > -1 and < 1 (make this neutral instead).

fatalbanana and others added some commits Oct 3, 2016

Rspamd plugin: Fix spambar for negative scores
 - Also avoid empty spambar for scores between -1 and 1
@msimerson

This comment has been minimized.

Show comment
Hide comment
@msimerson

msimerson Oct 3, 2016

Member

Hey @fatalbanana , I have created a PR against your branch that adds some basic tests for rspamd. Right now, they'll fail on Haraka/master@HEAD, but they should pass on this branch of yours. Please merge them into your branch (which I think will update this PR).

Also, feel free to add more tests and validate that other portions of the rspamd plugin are working as expected.

PS: you may need to run npm install haraka-test-fixtures to install the latest version, which has added support for message header manipulation.

Member

msimerson commented Oct 3, 2016

Hey @fatalbanana , I have created a PR against your branch that adds some basic tests for rspamd. Right now, they'll fail on Haraka/master@HEAD, but they should pass on this branch of yours. Please merge them into your branch (which I think will update this PR).

Also, feel free to add more tests and validate that other portions of the rspamd plugin are working as expected.

PS: you may need to run npm install haraka-test-fixtures to install the latest version, which has added support for message header manipulation.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 3, 2016

Current coverage is 35.83% (diff: 100%)

Merging #1630 into master will increase coverage by 0.09%

@@             master      #1630   diff @@
==========================================
  Files            26         26          
  Lines          6541       6541          
  Methods         849        849          
  Messages          0          0          
  Branches       1706       1706          
==========================================
+ Hits           2338       2344     +6   
+ Misses         4203       4197     -6   
  Partials          0          0          

Powered by Codecov. Last update 0826331...47a5f7f

codecov-io commented Oct 3, 2016

Current coverage is 35.83% (diff: 100%)

Merging #1630 into master will increase coverage by 0.09%

@@             master      #1630   diff @@
==========================================
  Files            26         26          
  Lines          6541       6541          
  Methods         849        849          
  Messages          0          0          
  Branches       1706       1706          
==========================================
+ Hits           2338       2344     +6   
+ Misses         4203       4197     -6   
  Partials          0          0          

Powered by Codecov. Last update 0826331...47a5f7f

@msimerson msimerson merged commit ee66a96 into haraka:master Oct 3, 2016

3 checks passed

codecov/patch Coverage not affected when comparing 0826331...47a5f7f
Details
codecov/project 35.83% (+0.09%) compared to 0826331
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment