do not set timer if timeout=0 #1632

Merged
merged 1 commit into from Oct 5, 2016

Conversation

Projects
None yet
2 participants
@msimerson
Member

msimerson commented Oct 3, 2016

Fixes #1534

Changes proposed in this pull request:

  • when plugin.timeout =0, don't set a tls timer

This essentially does what one expects (after reading the docs) and setting plugin.timeout=0. However, it might be better to instead use a default (30s) timer. Thoughts?

@msimerson msimerson added the Bug Fix label Oct 3, 2016

@smfreegard smfreegard merged commit c5f11af into haraka:master Oct 5, 2016

3 checks passed

codecov/patch Coverage not affected when comparing e1ec428...313c69a
Details
codecov/project 35.86% (+0.00%) compared to e1ec428
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@msimerson msimerson deleted the msimerson:tls-plugin-timeout-zero branch Oct 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment