remove ./net_utils to haraka-net-utils #1644

Merged
merged 1 commit into from Oct 8, 2016

Conversation

Projects
None yet
1 participant
@msimerson
Member

msimerson commented Oct 6, 2016

Changes proposed in this pull request:

  • removes ./net_utils to haraka-net-utils (github, npm)
  • updates plugins that require it
  • replaces (5x) instances of logger.logerror with console.error (as haraka-net-utils can't load ./logger)
    • in these cases, the log messages were pretty low-value, but it'd be nice to detangle logger so it can be loaded by external libs

Checklist:

  • docs updated
  • tests updated

@msimerson msimerson added this to the Plugins as NPM modules milestone Oct 6, 2016

@msimerson

This comment has been minimized.

Show comment
Hide comment
@msimerson

msimerson Oct 7, 2016

Member

In addition to the test suite, I've now tested this in production for a few hours with no ill effect.

Member

msimerson commented Oct 7, 2016

In addition to the test suite, I've now tested this in production for a few hours with no ill effect.

@msimerson msimerson referenced this pull request Oct 7, 2016

Merged

connection plugins: asn & geoip #1645

2 of 2 tasks complete

@msimerson msimerson merged commit 7aad461 into haraka:master Oct 8, 2016

3 checks passed

codecov/patch Coverage not affected when comparing 34fecb2...b5c5f26
Details
codecov/project Absolute coverage decreased by -1.44% but relative coverage increased by +64.14% compared to 34fecb2
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@msimerson msimerson deleted the msimerson:external-net-utils branch Oct 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment