connection plugins: asn & geoip #1645

Merged
merged 4 commits into from Oct 10, 2016

Conversation

Projects
None yet
2 participants
@msimerson
Member

msimerson commented Oct 7, 2016

  • Fixes #1493 (geoip v2 db support)
  • Depends on #1644 (haraka-net-utils)
  • Related to #1287 (plugins as NPM modules)

Changes proposed in this pull request:

  • replaces connect.geoip with haraka-plugin-geoip
  • replaces connect.asn with haraka-plugin-asn
  • looks for 'haraka-plugin-' + valueFromConfigPluginsFile for plugin path
    • which is where npm will have installed it
    • and permits putting 'geoip' in config/plugins instead of haraka-plugin-geoip

Checklist:

  • docs updated
  • tests updated

@msimerson msimerson changed the title from Connection plugins to Connection plugins: asn & geoip Oct 7, 2016

@msimerson msimerson changed the title from Connection plugins: asn & geoip to connection plugins: asn & geoip Oct 7, 2016

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 8, 2016

Current coverage is 34.41% (diff: 0.00%)

Merging #1645 into master will not change coverage

@@             master      #1645   diff @@
==========================================
  Files            25         25          
  Lines          6381       6381          
  Methods         825        825          
  Messages          0          0          
  Branches       1664       1664          
==========================================
  Hits           2196       2196          
  Misses         4185       4185          
  Partials          0          0          

Powered by Codecov. Last update d9252c1...631e95a

codecov-io commented Oct 8, 2016

Current coverage is 34.41% (diff: 0.00%)

Merging #1645 into master will not change coverage

@@             master      #1645   diff @@
==========================================
  Files            25         25          
  Lines          6381       6381          
  Methods         825        825          
  Messages          0          0          
  Branches       1664       1664          
==========================================
  Hits           2196       2196          
  Misses         4185       4185          
  Partials          0          0          

Powered by Codecov. Last update d9252c1...631e95a

@msimerson msimerson merged commit 57288f7 into haraka:master Oct 10, 2016

2 of 3 checks passed

codecov/patch 0.00% of diff hit (target 34.41%)
Details
codecov/project 34.41% remains the same compared to d9252c1
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@msimerson msimerson deleted the msimerson:connection-plugins branch Oct 10, 2016

@msimerson msimerson added this to the Plugins as NPM modules milestone Oct 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment