New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connection.remote.is_private #1648

Merged
merged 3 commits into from Oct 10, 2016

Conversation

Projects
None yet
2 participants
@msimerson
Member

msimerson commented Oct 9, 2016

Fixes #1631

Changes proposed in this pull request:

  • set connect.remote.is_private boolean
  • update plugins to check that connection property

Checklist:

  • docs updated (in #1650)
  • tests updated
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 9, 2016

Current coverage is 34.54% (diff: 100%)

Merging #1648 into master will increase coverage by 0.13%

@@             master      #1648   diff @@
==========================================
  Files            25         25          
  Lines          6381       6385     +4   
  Methods         825        825          
  Messages          0          0          
  Branches       1664       1665     +1   
==========================================
+ Hits           2196       2206    +10   
+ Misses         4185       4179     -6   
  Partials          0          0          

Powered by Codecov. Last update e5460dd...6966f7b

codecov-io commented Oct 9, 2016

Current coverage is 34.54% (diff: 100%)

Merging #1648 into master will increase coverage by 0.13%

@@             master      #1648   diff @@
==========================================
  Files            25         25          
  Lines          6381       6385     +4   
  Methods         825        825          
  Messages          0          0          
  Branches       1664       1665     +1   
==========================================
+ Hits           2196       2206    +10   
+ Misses         4185       4179     -6   
  Partials          0          0          

Powered by Codecov. Last update e5460dd...6966f7b

@msimerson msimerson merged commit 1340b4e into haraka:master Oct 10, 2016

3 checks passed

codecov/patch 100% of diff hit (target 34.41%)
Details
codecov/project 34.54% (+0.13%) compared to e5460dd
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@msimerson msimerson deleted the msimerson:connection-private-ip branch Oct 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment