More tls opts #1651

Merged
merged 5 commits into from Oct 10, 2016

Conversation

Projects
None yet
4 participants
@typingArtist
Collaborator

typingArtist commented Oct 10, 2016

Added quite some important TLS security options.

  • select location of key and cert
  • enable cipher order based on server list
  • add options for dhparam and EC curve selection
  • allow selection of the OpenSSL "method"

[x] docs updated
[x] no tests needed updating

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 10, 2016

Current coverage is 34.41% (diff: 100%)

Merging #1651 into master will not change coverage

@@             master      #1651   diff @@
==========================================
  Files            25         25          
  Lines          6381       6381          
  Methods         825        825          
  Messages          0          0          
  Branches       1664       1664          
==========================================
  Hits           2196       2196          
  Misses         4185       4185          
  Partials          0          0          

Powered by Codecov. Last update e5460dd...f683761

codecov-io commented Oct 10, 2016

Current coverage is 34.41% (diff: 100%)

Merging #1651 into master will not change coverage

@@             master      #1651   diff @@
==========================================
  Files            25         25          
  Lines          6381       6381          
  Methods         825        825          
  Messages          0          0          
  Branches       1664       1664          
==========================================
  Hits           2196       2196          
  Misses         4185       4185          
  Partials          0          0          

Powered by Codecov. Last update e5460dd...f683761

@Dexus

This comment has been minimized.

Show comment
Hide comment
@Dexus

Dexus Oct 10, 2016

Member

LGTM

Thank you for your PR.

Von meinem iPhone gesendet

Am 10.10.2016 um 13:56 schrieb typingArtist notifications@github.com:

Added quite some important TLS security options.

select location of key and cert
enable cipher order based on server list
add options for dhparam and EC curve selection
allow selection of the OpenSSL "method"
[x] docs updated
[x] no tests needed updating

You can view, comment on, or merge this pull request online at:

#1651

Commit Summary

transformed key and cert into options
added honorCipherOrder, ecdhCurve, dhparam and secureProtocol TLS options
added docs for new tls parameters
added docs for secureProtocol tls option
fixed dhparam handling
File Changes

M docs/plugins/tls.md (35)
M plugins/tls.js (24)
Patch Links:

https://github.com/haraka/Haraka/pull/1651.patch
https://github.com/haraka/Haraka/pull/1651.diff

You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Member

Dexus commented Oct 10, 2016

LGTM

Thank you for your PR.

Von meinem iPhone gesendet

Am 10.10.2016 um 13:56 schrieb typingArtist notifications@github.com:

Added quite some important TLS security options.

select location of key and cert
enable cipher order based on server list
add options for dhparam and EC curve selection
allow selection of the OpenSSL "method"
[x] docs updated
[x] no tests needed updating

You can view, comment on, or merge this pull request online at:

#1651

Commit Summary

transformed key and cert into options
added honorCipherOrder, ecdhCurve, dhparam and secureProtocol TLS options
added docs for new tls parameters
added docs for secureProtocol tls option
fixed dhparam handling
File Changes

M docs/plugins/tls.md (35)
M plugins/tls.js (24)
Patch Links:

https://github.com/haraka/Haraka/pull/1651.patch
https://github.com/haraka/Haraka/pull/1651.diff

You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@msimerson msimerson merged commit a1f5f05 into haraka:master Oct 10, 2016

3 checks passed

codecov/patch Coverage not affected when comparing e5460dd...f683761
Details
codecov/project 34.41% (+0.00%) compared to e5460dd
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@msimerson

This comment has been minimized.

Show comment
Hide comment
Member

msimerson commented Oct 10, 2016

thanks @typingArtist !

@msimerson msimerson added the Security label Oct 10, 2016

@typingArtist typingArtist deleted the typingArtist:more_tls_opts branch Oct 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment