move watch plugin to npm #1657

Merged
merged 2 commits into from Oct 11, 2016

Conversation

Projects
None yet
2 participants
@msimerson
Member

msimerson commented Oct 11, 2016

Changes proposed in this pull request:

  • removes most of watch plugin
  • adds dependency on haraka-plugin-watch
  • remove a little redundancy in plugins.js
  • replace legacy watch plugin with placeholder
  • make haraka-plugin- 2nd highest precedence

See also: discussion in #1658

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 11, 2016

Current coverage is 35.89% (diff: 100%)

Merging #1657 into master will increase coverage by 1.36%

@@             master      #1657   diff @@
==========================================
  Files            25         24     -1   
  Lines          6388       6073   -315   
  Methods         825        784    -41   
  Messages          0          0          
  Branches       1668       1536   -132   
==========================================
- Hits           2206       2180    -26   
+ Misses         4182       3893   -289   
  Partials          0          0          

Powered by Codecov. Last update b3ce582...d0f2ab3

codecov-io commented Oct 11, 2016

Current coverage is 35.89% (diff: 100%)

Merging #1657 into master will increase coverage by 1.36%

@@             master      #1657   diff @@
==========================================
  Files            25         24     -1   
  Lines          6388       6073   -315   
  Methods         825        784    -41   
  Messages          0          0          
  Branches       1668       1536   -132   
==========================================
- Hits           2206       2180    -26   
+ Misses         4182       3893   -289   
  Partials          0          0          

Powered by Codecov. Last update b3ce582...d0f2ab3

msimerson added some commits Oct 11, 2016

move watch plugin to npm
* add disabled entry in config/plugins for watch & limit
* remove redundancy from plugins.js
* replace legacy watch plugin with placeholder

@msimerson msimerson merged commit a47264d into haraka:master Oct 11, 2016

3 checks passed

codecov/patch 100% of diff hit (target 34.53%)
Details
codecov/project 35.89% (+1.36%) compared to b3ce582
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@msimerson msimerson deleted the msimerson:remove-watch-plugin-to-npm branch Oct 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment