New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct smtp_forward cfg for multiple rcpts #1680

Merged
merged 2 commits into from Oct 20, 2016

Conversation

Projects
None yet
3 participants
@msimerson
Member

msimerson commented Oct 20, 2016

Fixes #1679

Changes proposed in this pull request:

  • correctly compare destination hosts for multiple recipients
  • add test coverage
  • add config file wildcard boolean support
    • so arbitrary ini sections names like example.com can have boolean properties like enable_tls
  • update tests to use haraka-test-fixtures.transaction()

Checklist:

  • docs updated
  • tests updated
@godsflaw

This comment has been minimized.

Show comment
Hide comment
@godsflaw

godsflaw Oct 20, 2016

Collaborator

+1 on 🍵

Collaborator

godsflaw commented Oct 20, 2016

+1 on 🍵

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 20, 2016

Current coverage is 35.97% (diff: 100%)

Merging #1680 into master will increase coverage by 0.01%

@@             master      #1680   diff @@
==========================================
  Files            24         24          
  Lines          6075       6076     +1   
  Methods         785        785          
  Messages          0          0          
  Branches       1535       1536     +1   
==========================================
+ Hits           2185       2186     +1   
  Misses         3890       3890          
  Partials          0          0          

Powered by Codecov. Last update 92cd075...425f32a

codecov-io commented Oct 20, 2016

Current coverage is 35.97% (diff: 100%)

Merging #1680 into master will increase coverage by 0.01%

@@             master      #1680   diff @@
==========================================
  Files            24         24          
  Lines          6075       6076     +1   
  Methods         785        785          
  Messages          0          0          
  Branches       1535       1536     +1   
==========================================
+ Hits           2185       2186     +1   
  Misses         3890       3890          
  Partials          0          0          

Powered by Codecov. Last update 92cd075...425f32a

@msimerson msimerson merged commit 13d364a into haraka:master Oct 20, 2016

3 checks passed

codecov/patch 100% of diff hit (target 35.96%)
Details
codecov/project 35.97% (+0.01%) compared to 92cd075
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@msimerson msimerson deleted the msimerson:1679-smtp_forward-multiple-rcpt branch Oct 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment